Thread (18 messages) flat view 18 messages, 5 authors, 2021-05-17

Re: [PATCH 4/6] PCI: keystone: Convert to using hierarchy domain for legacy interrupts

From: Krzysztof Wilczyński <hidden>
Date: 2021-03-26 06:58:58
Also in: linux-arm-kernel, linux-pci, lkml

Hi Kishon,

Thank you for sending the series over!

A few small nitpick, so feel free to ignore it.

[...]
+	ret = irq_domain_alloc_irqs_parent(domain, virq, 1, &parent_fwspec);
+	if (ret < 0) {
+		pr_err("Failed to allocate parent irq %u: %d\n",
+		       parent_fwspec.param[0], ret);
+		return ret;
[...]

Use "IRQ" in the message above.

Also, the error messages with both starting with upper- and lower- case
letter, not sure if this is because of dev_err() vs pr_err(), but if
there is no significance between these two methods, then it might be
nice to keep the style consistent.

Krzysztof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help