Re: [PATCH V3 XRT Alveo 03/18] fpga: xrt: xclbin file helper functions

On 2/26/21 1:23 PM, Lizhi Hou wrote:

Hi Tom,

snip

quoted

I also do not see a pragma pack, usually this is set of 1 so the compiler does not shuffle elements, increase size etc.

This data structure is shared with other tools. And the structure is well defined with reasonable alignment. It is compatible with all compilers we have tested. So pragma pack is not necessary.

You can not have possibly tested all the configurations since the kernel supports many arches and compilers.

If the tested existing alignment is ok, pragma pack should be a noop on your tested configurations.

And help cover the untested configurations.

Tom