Thread (15 messages) 15 messages, 4 authors, 2021-01-11

Re: [PATCH 4/4] net: ethernet: ravb: Name the AVB functional clock fck

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2021-01-08 14:14:44
Also in: linux-renesas-soc, lkml, netdev

Hi Adam,

On Tue, Jan 5, 2021 at 1:53 PM Adam Ford [off-list ref] wrote:
On Mon, Jan 4, 2021 at 4:41 AM Geert Uytterhoeven [off-list ref] wrote:
quoted
On Mon, Dec 28, 2020 at 10:32 PM Adam Ford [off-list ref] wrote:
quoted
The bindings have been updated to support two clocks, but the
original clock now requires the name fck to distinguish it
from the other.

Signed-off-by: Adam Ford <redacted>
Thanks for your patch!
quoted
--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c
@@ -2142,7 +2142,7 @@ static int ravb_probe(struct platform_device *pdev)

        priv->chip_id = chip_id;

-       priv->clk = devm_clk_get(&pdev->dev, NULL);
+       priv->clk = devm_clk_get(&pdev->dev, "fck");
This change is not backwards compatible, as existing DTB files do not
have the "fck" clock.  So the driver has to keep on assuming the first
clock is the functional clock, and this patch is thus not needed nor
desired.
Should I post a V2 with this removed, or can this patch just be excluded?
As far as I am concerned, it can just be excluded.
Patches 1 and 2+3 have to follow different maintainer paths anyway.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help