Re: [PATCH 4/4] net: ethernet: ravb: Name the AVB functional clock fck
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2021-01-04 10:42:44
Also in:
linux-renesas-soc, lkml, netdev
Hi Adam, On Mon, Dec 28, 2020 at 10:32 PM Adam Ford [off-list ref] wrote:
The bindings have been updated to support two clocks, but the original clock now requires the name fck to distinguish it from the other. Signed-off-by: Adam Ford <redacted>
Thanks for your patch!
quoted hunk ↗ jump to hunk
--- a/drivers/net/ethernet/renesas/ravb_main.c +++ b/drivers/net/ethernet/renesas/ravb_main.c@@ -2142,7 +2142,7 @@ static int ravb_probe(struct platform_device *pdev) priv->chip_id = chip_id; - priv->clk = devm_clk_get(&pdev->dev, NULL); + priv->clk = devm_clk_get(&pdev->dev, "fck");
This change is not backwards compatible, as existing DTB files do not have the "fck" clock. So the driver has to keep on assuming the first clock is the functional clock, and this patch is thus not needed nor desired.
if (IS_ERR(priv->clk)) {
error = PTR_ERR(priv->clk);
goto out_release;
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds