On Fri, Sep 18, 2020 at 03:29, Bruno Thomsen [off-list ref] wrote:

-----Original Message-----
From: Bruno Thomsen <redacted>
Sent: 2020年9月18日 3:29
To: Qiang Zhao <qiang.zhao@nxp.com>
Cc: Rob Herring <robh@kernel.org>; a.zummo@towertech.it;
alexandre.belloni@bootlin.com; linux-rtc@vger.kernel.org;
devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: rtc-2127: Add bindings for
nxp,rtc-2127.txt

Den man. 14. sep. 2020 kl. 09.08 skrev Qiang Zhao [off-list ref]:

quoted

On Fri, Sep 11, 2020 at 22:03, Rob Herring [off-list ref] wrote:

quoted

Please help to review as below, if it is ok, I will send the new version patch.

Thank you!

quoted

diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml

b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
new file mode 100644
index 0000000..809dd59

--- /dev/null
+++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml

@@ -0,0 +1,38 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id:
+https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi

+cetree.org%2Fschemas%2Frtc%2Fnxp%2Cpcf2127.yaml%23&data=02%7
C01%7

quoted

+Cqiang.zhao%40nxp.com%7C5a271aa3d1ed46ea578108d85b3ff9f6%7C686e
a1d3bc

quoted

+2b4c6fa92cd99c5c301635%7C0%7C0%7C637359677624002617&sdata
=UGZ9B6E

quoted

+xteIMvxc3zvPfr%2FjZVQuPD6DJ6b2kZ%2BOO%2BIA%3D&reserved=0
+$schema:
+https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi

+cetree.org%2Fmeta-schemas%2Fcore.yaml%23&data=02%7C01%7Cqiang
.zha

quoted

+o%40nxp.com%7C5a271aa3d1ed46ea578108d85b3ff9f6%7C686ea1d3bc2b4
c6fa92c

quoted

+d99c5c301635%7C0%7C0%7C637359677624002617&sdata=7P2m9OvIs
FS6Q2By9

quoted

+DNmK9Oq5Ff6B%2BNSEA4F7otTT8g%3D&reserved=0
+
+title: PCF RTCs
+
+maintainers:
+  - Qiang Zhao [off-list ref]
+
+allOf:
+  - $ref: "rtc.yaml#"
+
+properties:
+  compatible:
+    enum:
+      - nxp,pcf2127
+      - nxp,pcf2129

The device driver have 3 compatible strings, "nxp,pca2129" is missing.

Thank you for your reminder, I will add in next version.

/Bruno

quoted

+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  no-watchdog:
+    maxItems: 1
+
+  start-year: true
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+...

quoted

Documentation/devicetree/writing-schema.rst and about 1000 examples
in the kernel tree.

Rob

Best Regards
Qiang Zhao