Re: [PATCH 1/3] dt-bindings: rtc-2127: Add bindings for nxp,rtc-2127.txt
From: Bruno Thomsen <hidden>
Date: 2020-09-17 19:58:13
Also in:
linux-rtc, lkml
Den man. 14. sep. 2020 kl. 09.08 skrev Qiang Zhao [off-list ref]:
On Fri, Sep 11, 2020 at 22:03, Rob Herring [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Please help to review as below, if it is ok, I will send the new version patch. Thank you!diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml new file mode 100644 index 0000000..809dd59 --- /dev/null +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml@@ -0,0 +1,38 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/rtc/nxp,pcf2127.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: PCF RTCs + +maintainers: + - Qiang Zhao <qiang.zhao@nxp.com> + +allOf: + - $ref: "rtc.yaml#" + +properties: + compatible: + enum: + - nxp,pcf2127 + - nxp,pcf2129
The device driver have 3 compatible strings, "nxp,pca2129" is missing. /Bruno
+ + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + no-watchdog: + maxItems: 1 + + start-year: true + +required: + - compatible + - reg + +additionalProperties: false + +...quoted
Documentation/devicetree/writing-schema.rst and about 1000 examples in the kernel tree. Rob