Hi,

On 7/27/20 9:44 PM, Andy Shevchenko wrote:

On Mon, Jul 27, 2020 at 10:04 PM Martin Blumenstingl
[off-list ref] wrote:

quoted

On Mon, Jul 27, 2020 at 11:23 AM Amelie Delaunay [off-list ref] wrote:

quoted

quoted

-       p->activate_stm_id_vb_detection = true;
+       p->activate_stm_id_vb_detection =
+               !of_property_read_bool(np, "usb-role-switch");

the rest of params.c uses device_property_read_* instead of of_read_property_*
I thought I'd mention it so you can decide yourself whether this is
fine or needs to be changed

Better to change and leave all on one line.

Thank you both for your review. I'll change it in upcoming v5. I'm still 
not used to exceed the 80 columns :)

Regards,
Amelie

-- 
With Best Regards,
Andy Shevchenko