Thread (9 messages) 9 messages, 3 authors, 2020-07-28

Re: [PATCH v4 3/3] usb: dwc2: don't use ID/Vbus detection if usb-role-switch on STM32MP15 SoCs

From: Amelie DELAUNAY <hidden>
Date: 2020-07-28 07:27:58
Also in: linux-devicetree, linux-usb, lkml

Hi,

On 7/27/20 9:44 PM, Andy Shevchenko wrote:
On Mon, Jul 27, 2020 at 10:04 PM Martin Blumenstingl
[off-list ref] wrote:
quoted
On Mon, Jul 27, 2020 at 11:23 AM Amelie Delaunay [off-list ref] wrote:
quoted
quoted
-       p->activate_stm_id_vb_detection = true;
+       p->activate_stm_id_vb_detection =
+               !of_property_read_bool(np, "usb-role-switch");
the rest of params.c uses device_property_read_* instead of of_read_property_*
I thought I'd mention it so you can decide yourself whether this is
fine or needs to be changed
Better to change and leave all on one line.
Thank you both for your review. I'll change it in upcoming v5. I'm still 
not used to exceed the 80 columns :)

Regards,
Amelie
-- 
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help