Hi,
On Mon, Jun 22, 2020 at 10:58:59AM +0800, Frank Lee wrote:
quoted hunk ↗ jump to hunk
Add device tree binding Documentation details for A100 pinctrl driver,
whic has an r pin controller and a pin controller with more irq lines.
Signed-off-by: Frank Lee <redacted>
---
.../pinctrl/allwinner,sun4i-a10-pinctrl.yaml | 72 +++++++++++++---------
1 file changed, 43 insertions(+), 29 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml
index bfefd09..2ac5eb5 100644
--- a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml
@@ -48,6 +48,8 @@ properties:
- allwinner,sun9i-a80-r-pinctrl
- allwinner,sun50i-a64-pinctrl
- allwinner,sun50i-a64-r-pinctrl
+ - allwinner,sun50i-a100-pinctrl
+ - allwinner,sun50i-a100-r-pinctrl
- allwinner,sun50i-h5-pinctrl
- allwinner,sun50i-h6-pinctrl
- allwinner,sun50i-h6-r-pinctrl@@ -144,75 +146,87 @@ allOf:
# FIXME: We should have the pin bank supplies here, but not a lot of
# boards are defining it at the moment so it would generate a lot of
# warnings.
-
- if:
properties:
compatible:
enum:
- - allwinner,sun9i-a80-pinctrl
+ - allwinner,sun50i-a100-pinctrl
then:
properties:
interrupts:
- minItems: 5
- maxItems: 5
+ minItems: 7
+ maxItems: 7
else:
if:
properties:
compatible:
enum:
- - allwinner,sun6i-a31-pinctrl
- - allwinner,sun6i-a31s-pinctrl
- - allwinner,sun50i-h6-pinctrl
+ - allwinner,sun9i-a80-pinctrl
The diff is a bit of a mess here. I guess you just added a new if with
the A100 pinctrl compatible?
Also, since it's a new SoC and we don't really have to care about the
existing DT for boards, it would be great if you could make the gpio
banks supplies required.
Thanks!
Maxime