Re: [PATCH 1/2] arm64: dts: Add a device tree for the Librem5 phone

Hi,
On Fri, May 29, 2020 at 06:28:50PM +0200, Pavel Machek wrote:

Hi!

quoted

From: "Angus Ainslie (Purism)" <redacted>

Add a devicetree description for the Librem 5 phone. The early batches
that have been sold are supported as well as the mass-produced device
available later this year, see https://puri.sm/products/librem-5/

This boots to a working console with working WWAN modem, wifi usdhc,
IMU sensor device, proximity sensor, haptic motor, gpio keys, GNSS and LEDs.

Signed-off-by: Martin Kepplinger <redacted>
Signed-off-by: Angus Ainslie (Purism) <redacted>
Signed-off-by: Guido Günther <agx@sigxcpu.org>

quoted

+		blue {
+			label = "phone:blue:front";
+			label = "phone:green:front";
+			label = "phone:red:front";

Droid 4 uses "status-led:{red,green,blue}". Could this use same
naming?

Looking at leds-class.rst we don't have a useful devicename so
should that just be omitted and s.th. like

		label = "blue:status";
		label = "green:status";
		label = "red:status";

be used instead. If we want to map to current usage

		label = "blue:status";
		label = "green:boot";
		label = "red:charging";

would be even closer but since that is bound to change just going with
"status" would make sense.
Cheers,
 -- Guido

quoted

+			label = "lm3560:flash";
+			label = "lm3560:torch";

This is one LED, right? I'm pretty sure we don't want lm3560 in the
name... "main-camera:flash" would be better. Even better would be
something that's already in use.

quoted

+			label = "white:backlight_cluster";

Make this ":backlight", please. Again, we want something that's
already used.

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html