Re: [PATCHv1 15/19] power: supply: sbs-battery: add ability to disable charger broadcasts
From: Emil Velikov <hidden>
Date: 2020-05-15 15:00:36
Also in:
linux-pm, lkml
On 2020/05/13, Sebastian Reichel wrote:
From: Jean-Francois Dagenais <redacted> In certain designs, it is possible to add a battery on a populated i2c bus without an sbs compliant charger. In that case, the battery will un-necessarily and sometimes un-desirably master the bus trying to write info in the charger.
Nit: s/un-/un/
It is observed in many occasion that these battery "broadcasts" are even corrupting other ongoing master to slave communication. I.e. the multi-master support in the battery is inadequate. Thankfully, the CHARGER_MODE bit allows designers to disable that SBS battery behaviour. This needs to be done once when the battery is first seen on the bus. Signed-off-by: Jean-Francois Dagenais <redacted> [rebased code] Signed-off-by: Sebastian Reichel <redacted> ---
quoted hunk ↗ jump to hunk
@@ -1017,6 +1043,9 @@ static int sbs_probe(struct i2c_client *client, } chip->i2c_retry_count = chip->i2c_retry_count + 1; + chip->charger_broadcasts = !of_property_read_bool(client->dev.of_node, + "sbs,disable-charger-broadcasts"); +
This patch adds the of_property_read, only for it to be replaced in the next patch. Consider flipping the patch order? -Emil