Re: [PATCH v4 3/7] tpm: tpm_tis: rewrite "tpm_tis_req_canceled()"

On Tue, Mar 31, 2020 at 02:32:03PM +0300, amirmizi6@gmail.com wrote:

From: Amir Mizinski <redacted>

Using this function while read/write data resulted in aborted operation.
After investigating according to TCG TPM Profile (PTP) Specifications,
i found cancel should happen only if TPM_STS.commandReady bit is lit and
couldn't find a case when the current condition is valid.
Also only cmdReady bit need to be compared instead of the full lower status
register byte.

Signed-off-by: Amir Mizinski <redacted>

We don't care about spec's. We care about hardware and not all hardware
follows specifications.

Please fix the exact thing you want to fix (and please provide a fixes
tag).

/Jarkko