Thread (19 messages) 19 messages, 6 authors, 2020-04-01

Re: [PATCH v4 1/7] tpm: tpm_tis: Make implementation of read16 read32 write32 optional

From: Jarkko Sakkinen <hidden>
Date: 2020-03-31 12:04:35
Also in: linux-integrity, lkml

On Tue, Mar 31, 2020 at 02:32:01PM +0300, amirmizi6@gmail.com wrote:
From: Amir Mizinski <redacted>

Only tpm_tis can use memory mapped I/O, which is truly mapped into
the kernel's memory space. So using ioread16/ioread32/iowrite32 turn into a
straightforward pointer dereference.
Every other driver require more complicated operations to read more than 1
byte at a time and will just fall back to read_bytes/write_bytes.
Therefore, move this common code out of tpm_tis_spi into tpm_tis_core, so
that it is automatically used when low-level drivers do not implement the
specialized methods.

Co-developed-by: Alexander Steffen <redacted>
Signed-off-by: Alexander Steffen <redacted>
Signed-off-by: Amir Mizinski <redacted>
Reviewed-by: Jarkko Sakkinen <redacted>

/Jarkko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help