Thread (14 messages) 14 messages, 5 authors, 2020-03-31

Re: [PATCH v3 3/3] dt-bindings: thermal: Add yaml bindings for thermal zones

From: Daniel Lezcano <hidden>
Date: 2020-03-30 13:08:00
Also in: linux-arm-msm, linux-pm, lkml

Hi Amit,

On 30/03/2020 12:34, Amit Kucheria wrote:

[ ... ]
quoted
quoted
I don't know why it's not consistent with the actual code in
of-thermal.c, where there is even a comment stated: /* For now,
thermal framework supports only 1 sensor per zone */

I think this is the place where developers should be informed
about the limitation and not even try to put more sensors into
the list.
That is a good point. I'm currently "porting" the existing
binding as described in thermal.txt to yaml. If you look at some
of the example (c) in there, the bindings allow many sensors to a
zone mapping but the thermal core doesn't implement that
functionality.

So should we fix the core code or change the bindings? Thoughts -
Rob, Daniel, Rui?
Rob, Daniel: Any comments? We don't have any concerns for Linux
backward compatibility since multiple sensors per zone isn't used
anywhere. But asking since bindings are supposed to be
OS-agnostic.
IMO, we should remove it as it is not used anywhere.

We still have to decide how we aggregate multiple sensors.


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help