Hi Geert,

Geert Uytterhoeven, Fri, Mar 20, 2020 09:48:14 +0100:

On Fri, Mar 20, 2020 at 9:44 AM Alex Riesen [off-list ref] wrote:

quoted

Laurent Pinchart, Thu, Mar 19, 2020 19:01:25 +0100:

quoted

On Thu, Mar 19, 2020 at 06:42:36PM +0100, Alex Riesen wrote:

quoted

As the driver has some support for the audio interface of the device,
the bindings file should mention it.

quoted

quoted

quoted

@@ -16,6 +18,8 @@ Required Properties:
     slave device on the I2C bus. The main address is mandatory, others are
     optional and remain at default values if not specified.

+  - #clock-cells: must be <0> if the I2S port is used

Wouldn't it be simpler to set it to 0 unconditionally ?

Would it? If the port itself is optional, shouldn't the clock be an option
too?

You'd be surprised how many board designers would consider this a cheap
12.288 MHz clock source, without using the I2S port ;-)

Well, I am :-)

Especially considering that the driver will not switch the MCLK pin aktive
(all I2S-related pins are tristate by default).

And how do I require it to be set unconditionally? By just removing the
"if ..." part of the statement?

Regards,
Alex