Re: [PATCH v4 1/8] ASoC: dt-bindings: fsl_asrc: Change asrc-width to asrc-format

Hi

On Tue, Mar 3, 2020 at 8:47 PM Mark Brown [off-list ref] wrote:

On Tue, Mar 03, 2020 at 11:59:30AM +0800, Shengjiu Wang wrote:

quoted

On Tue, Mar 3, 2020 at 9:43 AM Rob Herring [off-list ref] wrote:

quoted

quoted

quoted

-   - fsl,asrc-width  : Defines a mutual sample width used by DPCM Back Ends.
+   - fsl,asrc-format : Defines a mutual sample format used by DPCM Back
+                       Ends. The value is one of SNDRV_PCM_FORMAT_XX in
+                       "include/uapi/sound/asound.h"

quoted

quoted

You can't just change properties. They are an ABI.

quoted

I have updated all the things related with this ABI in this patch series.
What else should I do?

Like Nicolin says you should continue to support the old stuff.  The
kernel should work with people's out of tree DTs too so simply updating
everything in the tree isn't enough.

Thanks for review, I will update patch in next version.

best regards
wang shengjiu