Re: [PATCH v4 1/8] ASoC: dt-bindings: fsl_asrc: Change asrc-width to asrc-format
From: Rob Herring <robh@kernel.org>
Date: 2020-03-03 01:41:37
Also in:
alsa-devel, linux-arm-kernel, linuxppc-dev, lkml
On Sun, Mar 01, 2020 at 01:24:12PM +0800, Shengjiu Wang wrote:
quoted hunk ↗ jump to hunk
asrc_format is more inteligent, which is align with the alsa definition snd_pcm_format_t, we don't need to convert it to format in driver, and it can distinguish S24_LE & S24_3LE. Signed-off-by: Shengjiu Wang <redacted> --- Documentation/devicetree/bindings/sound/fsl,asrc.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)diff --git a/Documentation/devicetree/bindings/sound/fsl,asrc.txt b/Documentation/devicetree/bindings/sound/fsl,asrc.txt index cb9a25165503..0cbb86c026d5 100644 --- a/Documentation/devicetree/bindings/sound/fsl,asrc.txt +++ b/Documentation/devicetree/bindings/sound/fsl,asrc.txt@@ -38,7 +38,9 @@ Required properties: - fsl,asrc-rate : Defines a mutual sample rate used by DPCM Back Ends. - - fsl,asrc-width : Defines a mutual sample width used by DPCM Back Ends. + - fsl,asrc-format : Defines a mutual sample format used by DPCM Back + Ends. The value is one of SNDRV_PCM_FORMAT_XX in + "include/uapi/sound/asound.h"
You can't just change properties. They are an ABI.
- fsl,asrc-clk-map : Defines clock map used in driver. which is required
by imx8qm/imx8qxp platform
--
2.21.0