Re: [PATCHv8 1/5] arm64: dts: qcom: sdm845: Add Coresight support

Hi Suzuki,

On 7/19/2019 3:16 PM, Suzuki K Poulose wrote:

Hi Sai,


On 12/07/2019 15:16, Sai Prakash Ranjan wrote:

quoted

Add coresight components found on Qualcomm SDM845 SoC.

Signed-off-by: Sai Prakash Ranjan <redacted>
Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Acked-by: Suzuki K Poulose <suzuki.poulose@arm.com>
---
  arch/arm64/boot/dts/qcom/sdm845.dtsi | 451 +++++++++++++++++++++++++++
  1 file changed, 451 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index 4babff5f19b5..5d7e3f8e0f91 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi

@@ -1815,6 +1815,457 @@

              clock-names = "xo";
          };
+        stm@6002000 {
+            compatible = "arm,coresight-stm", "arm,primecell";
+            reg = <0 0x06002000 0 0x1000>,
+                  <0 0x16280000 0 0x180000>;
+            reg-names = "stm-base", "stm-stimulus-base";
+
+            clocks = <&aoss_qmp>;
+            clock-names = "apb_pclk";
+
+            out-ports {
+                port {
+                    stm_out: endpoint {
+                        remote-endpoint =
+                          <&funnel0_in7>;
+                    };
+                };
+            };
+        };
+
+        funnel@6041000 {
+            compatible = "arm,coresight-funnel", "arm,primecell";

We added support for static funnels and have thus updated our DT bindings. And
that implies, the above binding is now obsolete.
As of the coresight/next tree, and thus linux-next, this must be arm,coresight-dynamic-funnel and same applies everywhere else in the series. Please could you
update the series ?

Sure, will update in the next version of the series.

Thanks,
Sai


-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation