Re: [PATCHv8 2/5] arm64: dts: qcom: msm8998: Add Coresight support
flat view
From: Suzuki K Poulose <suzuki.poulose@arm.com>
Date: 2019-07-18 08:28:54
Also in:
linux-arm-kernel, linux-arm-msm, lkml
Hi Sai, On 12/07/2019 15:16, Sai Prakash Ranjan wrote:
quoted hunk ↗ jump to hunk
Enable coresight support by adding device nodes for the available source, sinks and channel blocks on MSM8998. Signed-off-by: Sai Prakash Ranjan <redacted> Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org> Acked-by: Suzuki K Poulose <suzuki.poulose@arm.com> --- arch/arm64/boot/dts/qcom/msm8998.dtsi | 435 ++++++++++++++++++++++++++ 1 file changed, 435 insertions(+)diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi index c13ed7aeb1e0..ad9cb5e8675d 100644 --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi@@ -822,6 +822,441 @@
etr@6048000 {quoted hunk ↗ jump to hunk
+ compatible = "arm,coresight-tmc", "arm,primecell"; + reg = <0x06048000 0x1000>; + + clocks = <&rpmcc RPM_SMD_QDSS_CLK>, <&rpmcc RPM_SMD_QDSS_A_CLK>; + clock-names = "apb_pclk", "atclk"; + arm,scatter-gather;
Please could you confirm that you have tested the scatter-gather mode with ETR ? Either via perf/sysfs. Please could you share your results ? Unless verified this is going to be fatal for the system. Similarly for other platforms. Kind regards Suzuki