Re: [v4 4/6] dt-bindings: phy: Document the Synopsys MIPI DPHY Rx bindings
From: Rob Herring <robh@kernel.org>
Date: 2019-07-09 14:20:15
Also in:
linux-media, lkml
On Tue, Jun 11, 2019 at 09:20:53PM +0200, Luis Oliveira wrote:
Add device-tree bindings documentation for SNPS DesignWare MIPI D-PHY in RX mode. Signed-off-by: Luis Oliveira <redacted> --- Changelog v3-v4 - @Laurent I know I told you I could remove the snps,dphy-frequency on V3 but it is really useful for me here. I removed all other the proprietary properties except this one. Do you still think it must be removed? - Frequency units @Rob
Frequency units means append '-khz' to the property name. That also makes the 'frequency' part redundant, so maybe name it more around what the frequency is. The frequency for what? Rob
quoted hunk ↗ jump to hunk
.../devicetree/bindings/phy/snps,dw-dphy-rx.txt | 29 ++++++++++++++++++++++ 1 file changed, 29 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/snps,dw-dphy-rx.txtdiff --git a/Documentation/devicetree/bindings/phy/snps,dw-dphy-rx.txt b/Documentation/devicetree/bindings/phy/snps,dw-dphy-rx.txt new file mode 100644 index 0000000..50603e6 --- /dev/null +++ b/Documentation/devicetree/bindings/phy/snps,dw-dphy-rx.txt@@ -0,0 +1,29 @@ +Synopsys DesignWare MIPI Rx D-PHY block details + +Description +----------- + +The Synopsys MIPI D-PHY controller supports MIPI-DPHY in receiver mode. +Please refer to phy-bindings.txt for more information. + +Required properties: +- compatible : Shall be "snps,dw-dphy-rx". +- #phy-cells : Must be 1. +- bus-width : Size of the test interface data bus (8 bits->8 or + 12bits->12). +- snps,dphy-frequency : Frequency at which D-PHY should start, configurable. + Check Synopsys databook. (-kHz) +- reg : Test interface register. This correspondes to the + physical base address of the controller and size of + the device memory mapped registers; Check Synopsys + databook. + +Example: + + mipi_dphy_rx1: dphy@d00003040 { + compatible = "snps,dw-dphy-rx"; + #phy-cells = <1>; + bus-width = <12>; + snps,dphy-frequency = <300000>; + reg = <0xd0003040 0x20>; + };-- 2.7.4