Re: [v4 1/6] dt-bindings: media: Document bindings for DW MIPI CSI-2 Host
From: Sakari Ailus <sakari.ailus@iki.fi>
Date: 2019-06-28 14:13:47
Also in:
linux-media, lkml
Hi Luis, Thank you for the patchset. On Tue, Jun 11, 2019 at 09:20:50PM +0200, Luis Oliveira wrote:
quoted hunk ↗ jump to hunk
From: Luis Oliveira <redacted> Add bindings for Synopsys DesignWare MIPI CSI-2 host. Signed-off-by: Luis Oliveira <redacted> --- Changelog v3-v4 - remove "plat" from the block name @rob @laurent - remove "phy-names" when single-entry @rob - remove "snps,output-type" -> went to the driver config @laurent .../devicetree/bindings/media/snps,dw-csi.txt | 41 ++++++++++++++++++++++ 1 file changed, 41 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/snps,dw-csi.txtdiff --git a/Documentation/devicetree/bindings/media/snps,dw-csi.txt b/Documentation/devicetree/bindings/media/snps,dw-csi.txt new file mode 100644 index 0000000..613b7f9 --- /dev/null +++ b/Documentation/devicetree/bindings/media/snps,dw-csi.txt@@ -0,0 +1,41 @@ +Synopsys DesignWare CSI-2 Host controller + +Description +----------- + +This HW block is used to receive image coming from an MIPI CSI-2 compatible +camera. + +Required properties: +- compatible : shall be "snps,dw-csi" +- reg : physical base address and size of the device memory + mapped registers; +- interrupts : DW CSI-2 Host interrupts +- phys : List of one PHY specifier (as defined in + Documentation/devicetree/bindings/phy/phy-bindings.txt). + This PHY is a MIPI DPHY working in RX mode. +- resets : Reference to a reset controller (optional) + +The per-board settings: + - port sub-node describing a single endpoint connected to the camera as + described in video-interfaces.txt[1].
Which endpoint properties in video-interfaces.txt are relevant for the hardware? Which values may they have?
+
+Example:
+
+ csi2: csi2@3000 {
+ compatible = "snps,dw-csi";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = < 0x03000 0x7FF>;reg = <0x03000 0x7FF>;
+ phys = <&mipi_dphy_rx>;
+ resets = <&dw_rst 1>;
+ interrupts = <2>;
+
+ port@0 {
+ reg = <0>;You can drop "@0" and the reg property.
+ csi_ep1: endpoint {
+ remote-endpoint = <&camera_1>;
+ data-lanes = <1 2>;
+ };
+ };
+ };-- Kind regards, Sakari Ailus