Re: [PATCH 1/6] dt-bindings: soc: qcom: Add interconnect binding for GENI QUP
From: Georgi Djakov <hidden>
Date: 2019-01-23 18:35:38
Also in:
linux-arm-msm, linux-i2c, linux-serial, linux-spi, lkml
Hi Alok, Thanks for the patches! On 1/22/19 08:33, Alok Chauhan wrote:
Add documentation for the interconnect and interconnect-names bindings
s/interconnect /interconnects /
quoted hunk ↗ jump to hunk
for the GENI QUP as detailed by bindings/interconnect/interconnect.txt. Signed-off-by: Alok Chauhan <redacted> --- Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt | 10 ++++++++++ 1 file changed, 10 insertions(+)diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt index dab7ca9..44d7e02 100644 --- a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt@@ -17,6 +17,12 @@ Required properties if child node exists: - #address-cells: Must be <1> for Serial Engine Address - #size-cells: Must be <1> for Serial Engine Address Size - ranges: Must be present +- interconnects: phandle to a interconnect provider. Please refer
s/a interconnect/an interconnect/
quoted hunk ↗ jump to hunk
+ ../interconnect/interconnect.txt for details. + Must be 2 paths corresponding to 2 AXI ports. +- interconnect-names: Port names to differentiate between the + 2 interconnect paths defined with interconnect + specifier. Properties for children:@@ -67,6 +73,10 @@ Example: #size-cells = <1>; ranges; + interconnects = <&qnoc 11 &qnoc 512>, + <&qnoc 0 &qnoc 543>;
Please take a snippet from your patch 6/6 and put it here instead of the hard-coded integers above.
+ interconnect-names = "qup-memory", "qup-config";
+
i2c0: i2c@a94000 {
compatible = "qcom,geni-i2c";
reg = <0xa94000 0x4000>;When you post a new version, please change the subject of the patch series to PATCH v2, PATCH v3 etc, in order to be able to distinguish between different versions. Thanks, Georgi