Re: [PATCH v1 2/3] dt-bindings: crypto: document Exynos5433 SlimSSS
From: Kamil Konieczny <hidden>
Date: 2019-01-23 16:18:11
Also in:
linux-crypto, lkml
On 23.01.2019 08:59, Krzysztof Kozlowski wrote:
On Tue, 22 Jan 2019 at 16:26, Kamil Konieczny [off-list ref] wrote:quoted
Document DT bindings for crypto Samsung Exynos5433 SlimSSS (Slim Security SubSystem) IP. Signed-off-by: Kamil Konieczny <redacted> --- .../devicetree/bindings/crypto/samsung-sss.txt | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-)diff --git a/Documentation/devicetree/bindings/crypto/samsung-sss.txt b/Documentation/devicetree/bindings/crypto/samsung-sss.txt[...] - compatible : Should contain entries for this and backward compatible@@ -22,11 +27,13 @@ Required properties: - "samsung,s5pv210-secss" for S5PV210 SoC. - "samsung,exynos4210-secss" for Exynos4210, Exynos4212, Exynos4412, Exynos5250, Exynos5260 and Exynos5420 SoCs. + - "samsung,exynos5433-slim-sss" for Exynos542x and Exynos5433 SoCs.For Exynos5420 there is a driver for regular/full SSS module. It would be nice to explain what is the difference between them and/or mention potential conflicts of usage. The point is that previously we added drivers/bindings for SSS and now you use the other interface. It might be pretty confusing for users...
By the way, Exynos4 (Exynos4210, 4412) SSS do not have ARCFOUR (ARC4), nor TRNG nor Secure Key Manager. -- Best regards, Kamil Konieczny Samsung R&D Institute Poland