Re: [PATCH v1 2/3] dt-bindings: crypto: document Exynos5433 SlimSSS
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2019-01-23 08:00:13
Also in:
linux-crypto, lkml
On Tue, 22 Jan 2019 at 16:26, Kamil Konieczny [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Document DT bindings for crypto Samsung Exynos5433 SlimSSS (Slim Security SubSystem) IP. Signed-off-by: Kamil Konieczny <redacted> --- .../devicetree/bindings/crypto/samsung-sss.txt | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-)diff --git a/Documentation/devicetree/bindings/crypto/samsung-sss.txt b/Documentation/devicetree/bindings/crypto/samsung-sss.txt index 7a5ca56683cc..75718f86fe50 100644 --- a/Documentation/devicetree/bindings/crypto/samsung-sss.txt +++ b/Documentation/devicetree/bindings/crypto/samsung-sss.txt@@ -1,4 +1,4 @@ -Samsung SoC SSS (Security SubSystem) module +Samsung SoC SSS (Security SubSystem) and SlimSSS module The SSS module in S5PV210 SoC supports the following: -- Feeder (FeedCtrl)@@ -15,6 +15,11 @@ supports the following also: -- True Random Number Generator (TRNG) -- Secure Key Manager +The SlimSSS module in Exynos5 (Exynos5433) supports: +-- Feeder (FeedCtrl) +-- Advanced Encryption Standard (AES) +-- SHA-1/SHA-256/HMAC (SHA-1/SHA-256) + Required properties: - compatible : Should contain entries for this and backward compatible@@ -22,11 +27,13 @@ Required properties: - "samsung,s5pv210-secss" for S5PV210 SoC. - "samsung,exynos4210-secss" for Exynos4210, Exynos4212, Exynos4412, Exynos5250, Exynos5260 and Exynos5420 SoCs. + - "samsung,exynos5433-slim-sss" for Exynos542x and Exynos5433 SoCs.
For Exynos5420 there is a driver for regular/full SSS module. It would be nice to explain what is the difference between them and/or mention potential conflicts of usage. The point is that previously we added drivers/bindings for SSS and now you use the other interface. It might be pretty confusing for users... Best regards, Krzysztof
- reg : Offset and length of the register set for the module
- interrupts : interrupt specifiers of SSS module interrupts (one feed
control interrupt).
- clocks : list of clock phandle and specifier pairs for all clocks listed in
clock-names property.
-- clock-names : list of device clock input names; should contain one entry
- "secss".
+- clock-names : list of device clock input names; should contain "pclk" and
+ "aclk" for slim-sss in Exynos5433, and one entry "secss" for
+ other compatibles.
--
2.20.0