Hi,

On 12/12/18 12:22 PM, Felipe Balbi wrote:

quoted

Hi

Pawel Laszczak [off-list ref] writes:

quoted

quoted

quoted

+	cdns->phy = devm_phy_get(dev, "cdns3,usbphy");
+	if (IS_ERR(cdns->phy)) {
+		ret = PTR_ERR(cdns->phy);
+		if (ret == -ENOSYS || ret == -ENODEV) {

Are you sure you can get ENOSYS here? Have you checked output of
checkpatch --strict?
-:852: WARNING: ENOSYS means 'invalid syscall nr' and nothing else

Yes this error code can be returned by related to phy function if
CONFIG_GENERIC_PHY is disabled.

I have seen this warning in output of checkpatch --strict .

Kishon, seems like you shouldn't be using that error value.

hmm, yeah should change the return value to -ENODEV when GENERIC_PHY is disabled.

So I will remove this ENOSYS from next patch. I assume that it will be removed also from generic phy driver. 

Thanks,
Pawel