Thread (33 messages) 33 messages, 9 authors, 2018-12-31

RE: [PATCH v1 2/2] usb:cdns3 Add Cadence USB3 DRD Driver

From: Felipe Balbi <balbi@kernel.org>
Date: 2018-12-11 12:15:50
Also in: linux-usb, lkml

Hi,

Pawel Laszczak [off-list ref] writes:
quoted
I think what Felipe meant was to only combine the gadget driver code into one patch.

The series could be split into 6 patches like so.
-dt binding
-pci glue
-core driver
-host driver
-gadget driver
-drd driver
Felipe wrote:
" 
Frankly, I don't understand why this is a series. It's a single driver
and splitting it into a series just makes it more difficult to review,
actually.

Sure, a single patch will be large, but there's no way to have a
functional driver until all patches are applied, anyway.
"

Felipe should I split this driver as suggested by Roger ?. 
Now it's very big patch but it's still a single driver.
don't bother. It's far easier to review as it is.

-- 
balbi

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help