Re: [PATCH v5 3/5] arm64: dts: qcom: sdm845: add UFS controller
From: Bjorn Andersson <hidden>
Date: 2018-11-22 07:18:53
Also in:
linux-arm-msm, lkml
On Fri 26 Oct 10:35 PDT 2018, Evan Green wrote:
quoted hunk ↗ jump to hunk
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi index b72bdb0a31a5..9c72edb678ec 100644 --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi@@ -808,6 +808,73 @@ }; }; + ufshc1: ufshc@1d84000 {
There's only one ufshc and one ufsphy, so no need to include the index. [..]
+ resets = <&gcc GCC_UFS_PHY_BCR>; + reset-names = "rst";
I have this as well, but this is not used by the upstream driver nor is it mentioned in the dt-binding.
+
+ status = "disabled";
+ };
+
+ ufsphy1: phy@1d87000 {With reservation for the "reset" issue: Reviewed-by: Bjorn Andersson <redacted> Regards, Bjorn