Thread (9 messages) 9 messages, 2 authors, 2018-09-10

Re: [PATCH v3] clk: renesas: cpg-mssr: Add R7S9210 support

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2018-09-05 14:31:08
Also in: linux-clk, linux-renesas-soc

Hi Chris,

On Wed, Sep 5, 2018 at 4:12 PM Chris Brandt [off-list ref] wrote:
On Wednesday, August 29, 2018, Chris Brandt wrote:
quoted
Add support for the R7S9210 (RZ/A2) Clock Pulse Generator and Module
Standby.
I ran into an issue with this driver.

The issue is that the registers needed for this driver are scattered
throughout the address space.

I can't just reserve one big block of addresses that cover everything
because then I can't reserve any of the addresses that sit in the middle.
Yeah, this address range is kind of a "syscon" block.
For example, my watchdog timer driver doesn't work with this driver
because it cannot allocate its register region.

So, I think I need to rework this driver to add the ability to add
multiple address regions.
Your main driver for this block (clock?) can register the watchdog.
Either directly with the watchdog subsystem, or by registering an
"rza_wdt" platform device.

One more vote for a separate rza2-cpg-stb-wdt driver?...

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help