Thread (9 messages) 9 messages, 2 authors, 2018-09-10

RE: [PATCH v3] clk: renesas: cpg-mssr: Add R7S9210 support

From: Chris Brandt <Chris.Brandt@renesas.com>
Date: 2018-09-05 15:02:19
Also in: linux-clk, linux-renesas-soc

Hi Geert,

On Wednesday, September 05, 2018 1, Geert Uytterhoeven wrote:
quoted
So, I think I need to rework this driver to add the ability to add
multiple address regions.
Your main driver for this block (clock?) can register the watchdog.
Either directly with the watchdog subsystem, or by registering an
"rza_wdt" platform device.
It would seem strange that the clock driver would register the watchdog 
timer for no other reason other than where the chip designer happen to 
put the register addresses.


Now that I look at it:
 CPG is at FCFE_0010 - FCFE_0104
MSTP is at FCFE_0400 - FCFE_0464

Nothing sits in between CPG and MSTP.

In the hardware manual, there is other 'random other stuff' that they 
put in that chapter that is located in multiple address places, but that 
doesn't mean I have to map them all in this driver.


I simply changed the DTS to just map CPG and MSTP and now everything is 
fine. My watchdog driver is happy and this CPG/MSTP driver works the 
same.

So....I guess I didn't really have an issue after all.

Chris
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help