Re: [PATCH v2 1/6] dt-bindings: reset: Add PDC Global binding for SDM845 SoCs
From: Matthias Kaehlcke <mka@chromium.org>
Date: 2018-08-28 17:12:10
Also in:
linux-arm-msm, linux-remoteproc, lkml
On Tue, Aug 28, 2018 at 11:38:26AM +0530, sibis@codeaurora.org wrote:
Hi Matthias, Thanks for the review On 2018-08-28 06:08, Matthias Kaehlcke wrote:quoted
Hi Sibi, On Fri, Aug 24, 2018 at 06:48:55PM +0530, Sibi Sankar wrote:quoted
Add PDC Global(Power Domain Controller) binding for SDM845 SoCs.nit: missing blank before the opening parenthesis.Will fix itquoted
quoted
Signed-off-by: Sibi Sankar <redacted> --- .../bindings/reset/qcom,pdc-global.txt | 52 +++++++++++++++++++ include/dt-bindings/reset/qcom,sdm845-pdc.h | 20 +++++++ 2 files changed, 72 insertions(+) create mode 100644 Documentation/devicetree/bindings/reset/qcom,pdc-global.txt create mode 100644 include/dt-bindings/reset/qcom,sdm845-pdc.h diff --git a/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt b/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt new file mode 100644 index 000000000000..69f9edca9503--- /dev/null +++ b/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt@@ -0,0 +1,52 @@ +PDC Global +====================================== + +This binding describes a reset-controller found on PDC-Global(PowerDomain +Controller) block for Qualcomm Technologies Inc SDM845 SoCs.Are there other PDC reset controllers that aren't 'global'? Otherwise I'd suggest to use 'pdc-reset' instead of 'pdc-global', which is more specific and in line with the name of the driver added by this series. Or something like 'pdc-reset-global/main' if there are other controllers?These are the only reset lines found in the pdc-global register space. But as explained by Bjorn, wouldn't it be better to leave it as such since pdc-global best describes the hardware without being limited by the current functionality it is being used for?
If I understand Bjorn's reply on https://patchwork.kernel.org/patch/10575335/ correctly it is planned to use the 'pdc-global' compatible string in the future in some sort of MFD driver for the 'PDC Global' IP block, which then instantiates other drivers like the reset controller. In this case I agree that 'pdc-global' seems a reasonable choice.