Hi Rob, Jassi,


2018-08-23 23:12 GMT+09:00 Jassi Brar [off-list ref]:

On 23 August 2018 at 18:51, Rob Herring [off-list ref] wrote:

quoted

On Thu, Aug 23, 2018 at 12:38 AM Jassi Brar [off-list ref] wrote:

quoted

On 23 August 2018 at 10:48, Masahiro Yamada

quoted

quoted

quoted

If desired, I will export of_irq_count()
and use it from my driver.

If you don't want to leave too much footprint, you could do

  count = 0;
  while (of_irq_parse_one(dev, count, &irq) == 0) count++

of_irq_parse_one() is already exported.

Yes, but we really don't more users and drivers shouldn't be using it.
Grepping DT functions and when the only users are pretty much powerpc,
that's a good indication not to use the function.

And you don't want to use of_irq_count either. platform_irq_count is
what should be used here. It's already exported.

Thanks, platform_irq_count() is definitely better.

Yamada-san, for example, gpio-tegra.c infers the number of banks from
platform_irq_count() rather than the 'gpio-banks' property.

I did not platform_irq_count().  I will send v2 with it.

Thanks.


-- 
Best Regards
Masahiro Yamada