Hi Songjun,

On Tue, Aug 7, 2018 at 9:18 AM Wu, Songjun [off-list ref] wrote:

On 8/6/2018 5:29 PM, Geert Uytterhoeven wrote:

quoted

On Mon, Aug 6, 2018 at 10:58 AM Wu, Songjun [off-list ref] wrote:

quoted

The reason we add a new head file is also for two macros(LTQ_EARLY_ASC
and CPHYSADDR)
used by legacy product. We need to provide the no-op stub for these two
macro for new product.

No you don't. The line number should not be obtained by comparing the
resource address with a hardcoded base address.

This is the previous code. Now the line number is obtained from dts.

Note that obtaining line numbers from DTS has its own share of problems, when
considering DT overlays. I've replied to the patch adding the call to
of_alias_get_id().

We keep this code for the compatibility.

Referring to the conditional-compilation part in coding-style,
We add a header file to avoid using “#ifdef” in C file.

quoted

Perhaps the override of port->line should just be removed, as IIRC, the serial
core has already filled in that field with the (next available) line number?

Gr{oetje,eeting}s,

                        Geert--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds