Re: [PATCH v2 14/18] serial: intel: Add CCF support
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2018-08-03 05:56:46
Also in:
linux-clk, linux-mips, linux-serial, lkml
On Fri, Aug 03, 2018 at 11:02:33AM +0800, Songjun Wu wrote:
quoted hunk ↗ jump to hunk
Previous implementation uses platform-dependent API to get the clock. Those functions are not available for other SoC which uses the same IP. The CCF (Common Clock Framework) have an abstraction based APIs for clock. In future, the platform specific code will be removed when the legacy soc use CCF as well. Change to use CCF APIs to get clock and rate. So that different SoCs can use the same driver. Signed-off-by: Songjun Wu <redacted> --- Changes in v2: None drivers/tty/serial/lantiq.c | 11 +++++++++++ 1 file changed, 11 insertions(+)diff --git a/drivers/tty/serial/lantiq.c b/drivers/tty/serial/lantiq.c index 36479d66fb7c..35518ab3a80d 100644 --- a/drivers/tty/serial/lantiq.c +++ b/drivers/tty/serial/lantiq.c@@ -26,7 +26,9 @@ #include <linux/clk.h> #include <linux/gpio.h> +#ifdef CONFIG_LANTIQ #include <lantiq_soc.h> +#endif
That is never how you do this in Linux, you know better. Please go and get this patchset reviewed and signed-off-by from other internal Intel kernel developers before resending it next time. It is their job to find and fix your basic errors like this, not ours. greg k-h