Thread (29 messages) 29 messages, 5 authors, 2018-08-06

Re: [PATCH v8 1/6] ARM: imx6q: provide documentation for new fsl,pmic-stby-poweroff property

From: Lucas Stach <l.stach@pengutronix.de>
Date: 2018-08-06 16:49:45
Also in: linux-arm-kernel, linux-clk, lkml

Am Montag, den 06.08.2018, 02:34 +0000 schrieb Robin Gong:
quoted
quoted
quoted
Not all boards follow the reference design, that's a fact of
life.

Please look at the i.MX6Q reference manual. The sequence
implemented
in this patchset can be found as a valid way to power off the
system
in
"60.4.3 Power mode transitions" "Normal ON to OFF with external
PMIC", so there is hardly any way to argue that this is a board
specific quirk. This is one of the Freescale/NXP recommended
sequences to
turn off the system.
quoted
Okay, but could you add one more comment for this solution? RTC
alarm
and ONOFF Button wakeup feature can't be support in this case.
Enough to add it in to changelog? or should it go to the binding
documentation?
The binding doc is better.
Sorry, I disagree.

A binding is a way to describe a specific hardware layout, it isn't the
right place to advice a hardware designer on the implications of a
specific hardware implementation. The NXP hardware design guide is a
more suitable place for this information.

We also don't mention in random bindings that the system won't be able
to brew a fresh cup of coffee.

Regards,
Lucas
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help