Re: [PATCH v4 5/5] rtc: isl1219: add device tree docu
From: Denis OSTERLAND <hidden>
Date: 2018-07-18 07:55:17
Also in:
linux-rtc, lkml
Hello, Am Mittwoch, den 18.07.2018, 09:38 +0200 schrieb Alexandre Belloni:
Hi, On 10/07/2018 09:44:15+0000, Denis OSTERLAND wrote:quoted
+ +Optional properties: + + - "interrupt-names": list which may contains "irq" and "evdet" + - "interrupt-parent", "interrupts", "interrupts-extended": + for passing the interrupt line of the SoC connected to #IRQ pin + and #EVDET pin of the RTC chip. + - "isil,ev-evienb": if present bit can be set to disable event input pull-upI would use a clearer name for that property like isil,ev-pull-up-enabled. Also make it an int so 0 is disabling the pull-up (EVIENB set to 1) 1 is enabling the pull-up (EVIENB set to 0) and do nothing when the property is not present.
It is designed like Documentation/devicetree/bindings/rtc/isil,isl12026.txt, which uses the bit name from Documentation as well. I will change to integer type.
Regards Denis Diehl Connectivity Solutions GmbH Geschäftsführung: Horst Leonberger Sitz der Gesellschaft: Nürnberg - Registergericht: Amtsgericht Nürnberg: HRB 32315 ___________________________________________________________________________________________________ Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen. Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht. Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt. The contents of the above mentioned e-mail is not legally binding. This e-mail contains confidential and/or legally protected information. Please inform us if you have received this e-mail by mistake and delete it in such a case. Each unauthorized reproduction, disclosure, alteration, distribution and/or publication of this e-mail is strictly prohibited.