Re: [PATCH v4 5/5] rtc: isl1219: add device tree docu
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
Date: 2018-07-18 07:39:05
Also in:
linux-rtc, lkml
Hi, On 10/07/2018 09:44:15+0000, Denis OSTERLAND wrote:
quoted hunk ↗ jump to hunk
From: Denis Osterland <redacted> The devicetree documentation for the ISL1219 device tree binding is added with an short example. It is not a trivial device, because it supports two interrupt souces. Signed-off-by: Denis Osterland <redacted> --- .../devicetree/bindings/rtc/isil,isl1219.txt | 29 +++++++++++++++++++ 1 file changed, 29 insertions(+) create mode 100644 Documentation/devicetree/bindings/rtc/isil,isl1219.txtdiff --git a/Documentation/devicetree/bindings/rtc/isil,isl1219.txt b/Documentation/devicetree/bindings/rtc/isil,isl1219.txt new file mode 100644 index 000000000000..f26f1e9d4bde --- /dev/null +++ b/Documentation/devicetree/bindings/rtc/isil,isl1219.txt@@ -0,0 +1,29 @@ +Intersil ISL1219 I2C RTC/Alarm chip with event in + +ISL1219 has additional pins EVIN and #EVDET for tamper detection. + +Required properties supported by the device: + + - "compatible": must be "isil,isl1219" + - "reg": I2C bus address of the device + +Optional properties: + + - "interrupt-names": list which may contains "irq" and "evdet" + - "interrupt-parent", "interrupts", "interrupts-extended": + for passing the interrupt line of the SoC connected to #IRQ pin + and #EVDET pin of the RTC chip. + - "isil,ev-evienb": if present bit can be set to disable event input pull-up
I would use a clearer name for that property like isil,ev-pull-up-enabled. Also make it an int so 0 is disabling the pull-up (EVIENB set to 1) 1 is enabling the pull-up (EVIENB set to 0) and do nothing when the property is not present. -- Alexandre Belloni, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com