On 5/23/2018 3:57 AM, Robin Murphy wrote:

On 22/05/18 19:47, Ray Jui wrote:

quoted

Update the SP805 binding document to add optional 'timeout-sec'
devicetree property

Signed-off-by: Ray Jui <redacted>
Reviewed-by: Scott Branden <scott.branden@broadcom.com>
---
  Documentation/devicetree/bindings/watchdog/sp805-wdt.txt | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/watchdog/sp805-wdt.txt 

b/Documentation/devicetree/bindings/watchdog/sp805-wdt.txt
index edc4f0e..f898a86 100644

--- a/Documentation/devicetree/bindings/watchdog/sp805-wdt.txt
+++ b/Documentation/devicetree/bindings/watchdog/sp805-wdt.txt

@@ -19,6 +19,8 @@ Required properties:

  Optional properties:
  - interrupts : Should specify WDT interrupt number.
+- timeout-sec : Should specify default WDT timeout in seconds. If 
unset, the
+                default timeout is 30 seconds

According to the SP805 TRM, the default interval is dependent on the 
rate of WDOGCLK, but would typically be a lot longer than that :/

On a related note, anyone have any idea why we seem to have two subtly 
different SP805 bindings defined?

Interesting, I did not even know that until you pointed this out (and 
it's funny that I found that I actually reviewed arm,sp805.txt 
internally in Broadcom code review).

It looks like one was done by Bhupesh Sharma (sp805-wdt.txt) and the 
other was done by Anup Patel (arm,sp805.txt). Both were merged at the 
same time around March 20, 2016: 915c56bc01d6. I'd assume both were sent 
out at around the same time.

It sounds like we should definitely remove one of them. Given that 
sp805-wdt.txt appears to have more detailed descriptions on the use of 
the clocks, should we remove arm,sp805.txt?

Thanks,

Ray

Robin.

quoted

  Examples: