Thread (8 messages) 8 messages, 4 authors, 2018-03-27

Re: [PATCH V10 0/3] mtd: read partitions compatible prop for "ofpart" type

From: Boris Brezillon <hidden>
Date: 2018-03-27 09:41:30

On Wed, 14 Mar 2018 13:10:41 +0100
Rafał Miłecki [off-list ref] wrote:
From: Rafał Miłecki <rafal@milecki.pl>

This patchset provides a proper support for flash device DT node with
"partitions" subnode using "compatible" property. It's already
documented in the: Documentation/devicetree/bindings/mtd/partition.txt

We believed that version 7 was ready to go, but soon after landing in
the linux-next we got a regression report from Peter. Later versions
takes a safe path by:
1) Respecting parsers order as specified in the default/driver-provided
   list.
2) Looking at "compatible" property only when "ofpart" type gets
   speciied.

Version 9 was successfully tested by Peter and version 10 just squashes
two commits into a one.

I double-checked the code and cannot think of any regression this could
cause. I also hope this design (roughly discussed with Boris) can be
acceptable for the mtd subsystem.

The most important patch from this patchset (1/3) was reviewed by Rob in
the
[PATCH V6 1/2] mtd: partitions: add of_match_table parser matching
https://patchwork.ozlabs.org/comment/1831551/

If possible this is a 4.17 material.
Applied, finally. I'm still convinced putting this information in the
"partitions" node compatible is a bad idea because it adds extra
complexity to something that was already quite complex, but you won!

Note that Rob had comments on [1] that you never answered, so I'm not
even sure when we'll start seeing boards using this infrastructure.

[1]http://patchwork.ozlabs.org/patch/859690/

-- 
Boris Brezillon, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help