Thread (8 messages) 8 messages, 4 authors, 2018-03-27

Re: [PATCH V10 0/3] mtd: read partitions compatible prop for "ofpart" type

From: Richard Weinberger <richard@nod.at>
Date: 2018-03-26 11:30:15

Am Mittwoch, 14. März 2018, 13:10:41 CEST schrieb Rafał Miłecki:
From: Rafał Miłecki <rafal@milecki.pl>

This patchset provides a proper support for flash device DT node with
"partitions" subnode using "compatible" property. It's already
documented in the: Documentation/devicetree/bindings/mtd/partition.txt

We believed that version 7 was ready to go, but soon after landing in
the linux-next we got a regression report from Peter. Later versions
takes a safe path by:
1) Respecting parsers order as specified in the default/driver-provided
   list.
2) Looking at "compatible" property only when "ofpart" type gets
   speciied.

Version 9 was successfully tested by Peter and version 10 just squashes
two commits into a one.

I double-checked the code and cannot think of any regression this could
cause. I also hope this design (roughly discussed with Boris) can be
acceptable for the mtd subsystem.

The most important patch from this patchset (1/3) was reviewed by Rob in
the
[PATCH V6 1/2] mtd: partitions: add of_match_table parser matching
https://patchwork.ozlabs.org/comment/1831551/

If possible this is a 4.17 material.

Rafał Miłecki (3):
  mtd: partitions: add of_match_table parser matching for the "ofpart"
    type
  mtd: rename "ofpart" parser to "fixed-partitions" as it fits it better
  mtd: ofpart: add of_match_table with "fixed-partitions"

 drivers/mtd/mtdpart.c          | 116
+++++++++++++++++++++++++++++++++++++---- drivers/mtd/ofpart.c           | 
18 +++++--
 include/linux/mtd/partitions.h |   1 +
 3 files changed, 121 insertions(+), 14 deletions(-)
Series looks good to me.

Reviewed-by: Richard Weinberger <richard@nod.at>

Thanks,
//richard

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help