Re: [v2, 7/7] tty: serial: msm_geni_serial: Add serial driver support for GENI based QUP
From: Doug Anderson <dianders@chromium.org>
Date: 2018-02-23 19:05:00
Hi, On Fri, Jan 12, 2018 at 5:05 PM, Karthikeyan Ramasubramanian [off-list ref] wrote:
quoted hunk ↗ jump to hunk
This driver supports GENI based UART Controller in the Qualcomm SOCs. The Qualcomm Generic Interface (GENI) is a programmable module supporting a wide range of serial interfaces including UART. This driver support console operations using FIFO mode of transfer. Signed-off-by: Girish Mahadevan <redacted> Signed-off-by: Karthikeyan Ramasubramanian <redacted> Signed-off-by: Sagar Dharia <redacted> --- drivers/tty/serial/Kconfig | 10 + drivers/tty/serial/Makefile | 1 + drivers/tty/serial/qcom_geni_serial.c | 1414 +++++++++++++++++++++++++++++++++ 3 files changed, 1425 insertions(+) create mode 100644 drivers/tty/serial/qcom_geni_serial.cdiff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig index b788fee..1be30e5 100644 --- a/drivers/tty/serial/Kconfig +++ b/drivers/tty/serial/Kconfig@@ -1098,6 +1098,16 @@ config SERIAL_MSM_CONSOLE select SERIAL_CORE_CONSOLE select SERIAL_EARLYCON +config SERIAL_QCOM_GENI + tristate "QCOM on-chip GENI based serial port support"
Should this be bool instead of tristate? Guenter noticed that we'll get link errors if we try building this as a module. Specifically, he noted that the "qcom_geni_serial.c" file refers to "uart_console_device" and "uart_console_device" is not exported (and shouldn't be since a console has to be available before modules are loaded). -Doug