Re: [PATCH 6/6] arm64: dts: renesas: r8a77965: Add #interrupt-cells property

On Fri, Feb 23, 2018 at 11:06:07AM +0100, jacopo mondi wrote:

Hi Geert,

On Fri, Feb 23, 2018 at 10:27:16AM +0100, Geert Uytterhoeven wrote:

quoted

On Thu, Feb 22, 2018 at 8:06 PM, Jacopo Mondi [off-list ref] wrote:

quoted

Add "#interrupt-cells" property and "interrupt-controller" label to
"interrupt-controller@e61c0000" device node.

This silences the following DTC compiler warnings:
Warning (interrupts_property): Missing interrupt-controller or
interrupt-map property in /soc/interrupt-controller@e61c0000
Warning (interrupts_property): Missing #interrupt-cells in
interrupt-parent /soc/interrupt-controller@e61c000

Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

quoted

--- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi

@@ -316,6 +316,8 @@
                };

                intc_ex: interrupt-controller@e61c0000 {
+                       #interrupt-cells = <2>;
+                       interrupt-controller;
                        reg = <0 0xe61c0000 0 0x200>;
                        /* placeholder */

(bikeshedding) Should the placeholder be at the top of the node?

I would like it more too, but in M3-W dtsi:

		pciec0: pcie@fe000000 {
			reg = <0 0xfe000000 0 0x80000>;
			/* placeholder */
		};

So I kept using the same style everywhere here.

I can change it everywhere in this series to have placeholder at the
beginning of the node definition if you agree with that!

Either way is fine by me. But if we do change it lets change it everywhere.