Re: [PATCH v4] rtc: isl12026: Add driver.
From: Philippe Ombredanne <hidden>
Date: 2018-02-18 17:31:58
Also in:
linux-rtc, lkml
Hi David, On Fri, Feb 16, 2018 at 8:44 PM, David Daney [off-list ref] wrote:
The ISL12026 is a combination RTC and EEPROM device with I2C interface. The standard RTC driver interface is provided. The EEPROM is accessed via the NVMEM interface via the "eeprom0" directory in the sysfs entry for the device. Reviewed-by: Andy Shevchenko <redacted> Signed-off-by: David Daney <redacted>
<snip>
quoted hunk ↗ jump to hunk
--- /dev/null +++ b/drivers/rtc/rtc-isl12026.c@@ -0,0 +1,529 @@ +// SPDX-License-Identifier: GPL-2.0
<snip>
+MODULE_LICENSE("GPL");Your MODULE_LICENSE does not match your SPDX tag. Per module.h, GPL would mean GPL-2.0+ not GPL-2.0 It would be best if you can sync the two. -- Cordially Philippe Ombredanne