On Fri, Feb 16, 2018 at 11:19 PM, David Daney [off-list ref] wrote:

On 02/16/2018 12:13 PM, Andy Shevchenko wrote:

quoted

On Fri, Feb 16, 2018 at 9:44 PM, David Daney [off-list ref]
wrote:

quoted

quoted

+config RTC_DRV_ISL12026
+       tristate "Intersil ISL12026"

quoted

depends on OF

It doesn't depend on CONFIG_OF, it builds just fine without it.

OK.
But then it's useless.

depends on OF || COMPILE_TEST

quoted

quoted

+static struct i2c_driver isl12026_driver = {
+       .driver         = {
+               .name   = "rtc-isl12026",
+               .of_match_table = of_match_ptr(isl12026_dt_match),

quoted

/of_match_ptr//

of_match_ptr() needed if we build without CONFIG_OF

OK.
Have you tried to enable warnings?
You must get `defined but not used` one.

-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html