Thread (7 messages) 7 messages, 5 authors, 2018-02-05

Re: [PATCH v3 1/2] ARM: dts: imx25-pinfunc: Use consistent naming for eSDHC

From: Rob Herring <robh@kernel.org>
Date: 2018-02-05 06:12:41
Also in: linux-arm-kernel, lkml

On Wed, Jan 31, 2018 at 10:35:43PM +0100, Benoît Thébaudeau wrote:
This file had several naming inconsistencies for eSDHC:
 - the instances were named sometimes SDn, sometimes SDHCn, whereas they
   are named ESDHCn in the reference manual, e.g.:
     MX25_PAD_SD1_CMD__SD1_CMD
     MX25_PAD_D15__SDHC1_DAT7
 - the data ports were named sometimes DATAn, sometimes DATn like in the
   reference manual, e.g.:
     MX25_PAD_SD1_DATA0__SD1_DATA0
     MX25_PAD_D15__SDHC1_DAT7
 - in one case, the clock port was named DAT_CLK instead of CLK:
     MX25_PAD_CSI_D7__SDHC2_DAT_CLK

This change:
 - introduces new definitions using the naming from the reference
   manual,
 - keeps definitions using the legacy naming in order not to break
   compatibility for out-of-tree users (they can be removed later),
 - updates the in-tree files that were using the legacy naming.

Cc: Uwe Kleine-König <redacted>
Signed-off-by: Benoît Thébaudeau <redacted>
Acked-by: Uwe Kleine-König <redacted>
---
Changes v2 -> v3:
 - None.
Changes v1 -> v2:
 - New patch (suggested by Uwe).
---
 .../boot/dts/imx25-eukrea-mbimxsd25-baseboard.dts  | 12 ++--
 arch/arm/boot/dts/imx25-pdk.dts                    | 12 ++--
 arch/arm/boot/dts/imx25-pinfunc.h                  | 72 ++++++++++++++--------
 3 files changed, 60 insertions(+), 36 deletions(-)
Reviewed-by: Rob Herring <robh@kernel.org>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help