Re: [PATCH v6 19/36] nds32: VDSO support
From: Arnd Bergmann <arnd@arndb.de>
Date: 2018-02-06 08:48:17
Also in:
linux-arch, linux-serial, lkml, netdev
On Tue, Feb 6, 2018 at 8:41 AM, Vincent Chen [off-list ref] wrote:
quoted hunk ↗ jump to hunk
2018-01-18 18:28 GMT+08:00 Arnd Bergmann [off-list ref]:quoted
On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu [off-list ref] wrote:quoted
From: Greentime Hu <redacted> This patch adds VDSO support. The VDSO code is currently used for sys_rt_sigreturn() and optimised gettimeofday() (using the SoC timer counter). Signed-off-by: Vincent Chen <redacted> Signed-off-by: Greentime Hu <redacted>Acked-by: Arnd Bergmann <arnd@arndb.de>Dear Arnd Bergmann: We find a small bug here which make LTP 20170929 clock_getres01 fail. The bug is in __vdso_clock_getres() function. When argument res is NULL, -EFAULT error code is returned now. But, the returned value is 0 for SyS_clock_getres under the same conditions. Therefore, testcase thinks it is a bug. I will modify the code as below and add it in the next version patch if you think it is OK.@@ -209,7 +209,7 @@ static notrace int clock_getres_fallback( ... { if (res == NULL) - return -EFAULT; + return 0;
Ok. I don't know why that is the expected behavior (clock_getres
with a NULL argument makes little sense), but I can see that it
matches the regular syscall implementation.
Arnd