On Mon, Jan 22, 2018 at 1:09 PM, JeffyChen [off-list ref] wrote:

Hi Randy,


On 01/22/2018 10:15 AM, JeffyChen wrote:

quoted

Hi Randy,

On 01/22/2018 09:18 AM, Randy Li wrote:

quoted

quoted

Also the power domain driver could manage the clocks as well, I would
suggest to use pm_runtime_*.

actually the clocks required by pm domain may not be the same as what we
want to control here, there might be some clocks only be needed when
accessing mmu registers.

but i'm not very sure about that, will confirm it with Simon Xue.

confirmed with Simon, there might be some iommus don't have a pd, and the
CONFIG_PM could be disabled.

so it might be better to control clocks in iommu driver itself.

Agreed with Jeffy.

I'd give Reviewed-by, but this is my own patch reposted by Jeffy
(thanks!), so it wouldn't have any value. :)

Best regards,
Tomasz