Re: [PATCH] reset: ti-rstctrl: use the reset-simple driver

On 01/19/2018 05:49 PM, Tony Lindgren wrote:

* Suman Anna [off-list ref] [180119 23:30]:

quoted

On 01/19/2018 03:33 PM, Tony Lindgren wrote:

quoted

OK let's do some tests on that, I'll take a look at doing a dts
file over next few weeks.

You can look up the patches folder in the above repo, there are some
example nodes there already, they are rather straight-forward.

Just for reference, here's what I played with but keep getting
-EPROBE_DEFER somewhere during init.

Hmm, What's the baseline branch you are using - mainline, linux-next or
your for-next?

Regards,

Tony

	prm: prm@6000 {
		...
		ranges = <0 0x6000 0x3000>;

		prm_dsp: prm@400 {
			compatible = "simple-bus";
			#address-cells = <1>;
			#size-cells = <1>;
			ranges = <0 0x400 0x100>;

			dsp_rstctrl: rstctrl@10 {
				compatible = "ti,rstctrl";
				reg = <0x10 0x4>;
				#reset-cells = <1>;
			};
		};
		...
	};

	target-module@4a066000 {
		compatible = "ti,sysc-omap2", "ti,sysc";
		ti,hwmods = "mmu_dsp";
		reg = <0x4a066000 0x4>,
		      <0x4a066010 0x4>,
		      <0x4a066014 0x4>;
		reg-names = "rev", "sysc", "syss";
		ti,sysc-mask = <(SYSC_OMAP2_CLOCKACTIVITY |
				 SYSC_OMAP2_SOFTRESET |
				 SYSC_OMAP2_AUTOIDLE)>;
		ti,sysc-sidle = <SYSC_IDLE_FORCE>,
				<SYSC_IDLE_NO>,
				<SYSC_IDLE_SMART>;
		clocks = <&tesla_clkctrl OMAP4_DSP_CLKCTRL 0>;
		clock-names = "fck";
		resets = <&dsp_rstctrl 1>,
			 <&dsp_rstctrl 0>;
		reset-names = "rst2", "rst1";

We definitely do not want the two resets here for sure, as the rst2
belongs to the dsp core (I believe it would be a sibling node to mmu_dsp
here), and cannot be released from reset without programming the MMU and
loading the code.

regards
Suman

		#address-cells = <1>;
		#size-cells = <1>;
		ranges = <0 0x4a066000 0x1000>;

		mmu_dsp: mmu@0 {
			compatible = "ti,omap4-iommu";
			reg = <0 0x100>;
			interrupts = <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>;
			#iommu-cells = <0>;
		};
	};

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html