Thread (42 messages) 42 messages, 5 authors, 2018-03-05

Re: [PATCH 1/7] watchdog: JZ4740: Disable clock after stopping counter

From: Guenter Roeck <hidden>
Date: 2017-12-28 18:38:18
Also in: linux-mips, linux-watchdog, lkml

On 12/28/2017 08:29 AM, Paul Cercueil wrote:
Previously, the clock was disabled first, which makes the watchdog
component insensitive to register writes.

Signed-off-by: Paul Cercueil <redacted>
Reviewed-by: Guenter Roeck <redacted>
quoted hunk ↗ jump to hunk
---
  drivers/watchdog/jz4740_wdt.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/jz4740_wdt.c b/drivers/watchdog/jz4740_wdt.c
index 20627f22baf6..6955deb100ef 100644
--- a/drivers/watchdog/jz4740_wdt.c
+++ b/drivers/watchdog/jz4740_wdt.c
@@ -124,8 +124,8 @@ static int jz4740_wdt_stop(struct watchdog_device *wdt_dev)
  {
  	struct jz4740_wdt_drvdata *drvdata = watchdog_get_drvdata(wdt_dev);
  
-	jz4740_timer_disable_watchdog();
  	writeb(0x0, drvdata->base + JZ_REG_WDT_COUNTER_ENABLE);
+	jz4740_timer_disable_watchdog();
  
  	return 0;
  }
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help