Re: [RFC PATCH v12 4/5] PCI / PM: Add support for the PCIe WAKE# signal for OF
From: Andy Shevchenko <hidden>
Date: 2017-12-28 08:50:30
Also in:
linux-pci, linux-pm, lkml
From: Andy Shevchenko <hidden>
Date: 2017-12-28 08:50:30
Also in:
linux-pci, linux-pm, lkml
On Wed, 2017-12-27 at 09:30 -0600, Rob Herring wrote:
On Tue, Dec 26, 2017 at 7:32 PM, JeffyChen [off-list ref] wrote:
this new file does something similar to the pci-acpi.c and pci-mid.c..
pci-acpi.c has similar things to pci/of.c. The naming is just not consistent.
quoted
and i am agree the naming is not clear, maybe we can rename both of those files to something like pci-pm-***.c?At least pci-acpi.c is more than just PM functions, so that doesn't make sense. Given that all the ACPI related functions are in 1 file, we should do the same for DT.
quoted
but i have no idea about pci-mid.c or would it possible to have more platform pm ops in the future...maybe we should add some dependency in the Kconfig?
You may consider pci-mid.c as pci-sfi.c to some extend. So, in that sense it more looks like pci-of.c would be the name for DT case. -- Andy Shevchenko [off-list ref] Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html