Re: [PATCH V8 3/3] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values
From: Rob Herring <hidden>
Date: 2017-12-26 20:30:01
Also in:
linux-pm, lkml
On Mon, Dec 18, 2017 at 03:51:30PM +0530, Viresh Kumar wrote:
quoted hunk ↗ jump to hunk
On some platforms the exact frequency or voltage may be hidden from the OS by the firmware. Allow such configurations to pass magic values in the "opp-hz" or the "opp-microvolt" properties, which should be interpreted in a platform dependent way. Reviewed-by: Ulf Hansson <redacted> Signed-off-by: Viresh Kumar <redacted> --- Documentation/devicetree/bindings/opp/opp.txt | 6 ++++++ 1 file changed, 6 insertions(+)diff --git a/Documentation/devicetree/bindings/opp/opp.txt b/Documentation/devicetree/bindings/opp/opp.txt index 4e4f30288c8b..00a3bdbd0f1f 100644 --- a/Documentation/devicetree/bindings/opp/opp.txt +++ b/Documentation/devicetree/bindings/opp/opp.txt@@ -167,6 +167,12 @@ properties. functioning of the current device at the current OPP (where this property is present). + +On some platforms the exact frequency or voltage may be hidden from the OS by +the firmware and the "opp-hz" or the "opp-microvolt" properties may contain +magic values that represent the frequency or voltage in a firmware dependent +way, for example an index of an array in the firmware.
I'm still not convinced this is a good idea. If you have firmware partially managing things, then I think we should have platform specific bindings or drivers. This is complex enough I'm not taking silence from Stephen as an okay. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html